The option parser for create unnecessarily checks "$1" inside a case statement that matches "$1" in the first place. Also, use "$@", not "$*", as our caller is expecting "$1" "$2", not "$1c$2" (where c is the first character of IFS). Signed-off-by: Ramkumar Ramachandra <artagnon@xxxxxxxxx> --- git-stash.sh | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/git-stash.sh b/git-stash.sh index bbefdf6..0ede313 100755 --- a/git-stash.sh +++ b/git-stash.sh @@ -546,11 +546,8 @@ clear) clear_stash "$@" ;; create) - if test $# -gt 0 && test "$1" = create - then - shift - fi - create_stash "$*" && echo "$w_commit" + shift + create_stash "$@" && echo "$w_commit" ;; drop) shift -- 1.8.3.rc1.57.g4ac1522 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html