Jiang Xin <worldhello.net@xxxxxxxxx> writes:
> + putchar('\n');
> +
> + /* Display dels in "Would remove ..." format */
> + for_each_string_list_item(item, &del_list) {
> + qname = quote_path_relative(item->string, -1, &buf, *the_prefix);
> + printf(_(msg_would_remove), qname);
> + }
> + putchar('\n');
> + putchar('\n');
> +
> + /* Display dels in "Would remove ..." format */
> + for_each_string_list_item(item, &del_list) {
> + qname = quote_path_relative(item->string, -1, &buf, *the_prefix);
> + printf(_(msg_would_remove), qname);
> + }
> + putchar('\n');
These two pieces of code are surprisingly similar ... Shouldn't they be
factored into a small helper function?
> + /* Confirmation dialog */
> + printf(_("Remove ([y]es/[n]o/[e]dit) ? "));
To be more consistent with "git add -p", this should use [] instead of
(), and have no space before "?".
> + die(_("clean.requireForce defaults to true and neither -i, -n nor -f given; "
> "refusing to clean"));
That makes it a 85 characters message, and we usually break lines before
80. Adding \n after ";" (instead of a space) would be better IMO.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html