Re: [PATCH] Makefile: fix default regex settings on Darwin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, May 11, 2013 at 12:04 AM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
> David Aguilar wrote:
>
>> expecting success:
>> # if this test fails, re-build git with NO_REGEX=1
>> test-regex
>>
>> fatal: regex bug confirmed: re-build git with NO_REGEX=1
>
> Thanks.  Gah.  That means that regcomp() with REG_NEWLINE is letting
>
>         [^={} \t]+
>
> match the newline in
>
>         ={}\nfred
>
> despite the POSIX requirement
>
>         A <newline> in string shall not be matched by a period outside
>         a bracket expression or by any form of a non-matching list
>
> where
>
>         A non-matching list expression begins with a <circumflex> ('^')
>         and specifies a list that shall match any single-character
>         collating element except for the expressions represented in
>         the list after the leading <circumflex>.
>
> and if I understand you correctly, this is a regression in Apple
> libc. :(
>
> With the commit message modified to mention the "fatal: regex bug
> confirmed: re-build git with NO_REGEX=1" and uname -a output,
>
> Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>

Thanks. I can adjust the commit message and re-roll to make this patch 1/3.

> Do you know if this has been reported to Apple and
> openradar.appspot.com?

I checked and nope, there are no bug reports.  I tried to submit one
by creating a "new radar" but that page said to go to
bugreport.apple.com.

I tried to login there but after entering my credentials I got, "An
error has occurred. Please report the error to Apple Inc. by emailing
the error detail to devbugs@xxxxxxxxx."  Oh bother ;-)

I refreshed the page and finally got in.  I submitted a bug.. Problem # 13868200

I hop on this laptop to test for cross-platform issues (I'm a Linux
user myself ;-) and it's been pretty good at finding 'em.
--
David
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]