Felipe Contreras <felipe.contreras@xxxxxxxxx> writes:
>>> if (!author)
>>> - die ("Could not find author in commit %s",
>>> + die("Could not find author in commit %s",
>>> sha1_to_hex(commit->object.sha1));
>>
>> It looks like your simple replace didn't account for calls with
>> multiple lines. Now the remaining lines don't line up.
>> :-) There's several more places like this in the patch.
>
> AFAIK neither the git or the Linux code-style specify how multiple
> lines with open parenthesis should align.
Then the usual "follow the style of surrounding code" rule would
apply, no? It is clear that the original wants to align the opening
dq of "Could..." and 's' at the beginning of sha1_to_hex().
Why is it so hard for you to say "Good eyes, thanks"?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html