On Thu, May 9, 2013 at 4:50 AM, Felipe Contreras
<felipe.contreras@xxxxxxxxx> wrote:
> On Thu, May 9, 2013 at 3:46 AM, John Szakmeister <john@xxxxxxxxxxxxxxx> wrote:
>> On Wed, May 8, 2013 at 9:16 PM, Felipe Contreras
[snip]
>>> @@ -289,13 +289,13 @@ static void handle_commit(struct commit *commit, struct rev_info *rev)
>>> parse_commit(commit);
>>> author = strstr(commit->buffer, "\nauthor ");
>>> if (!author)
>>> - die ("Could not find author in commit %s",
>>> + die("Could not find author in commit %s",
>>> sha1_to_hex(commit->object.sha1));
>>
>> It looks like your simple replace didn't account for calls with
>> multiple lines. Now the remaining lines don't line up.
>> :-) There's several more places like this in the patch.
>
> AFAIK neither the git or the Linux code-style specify how multiple
> lines with open parenthesis should align.
True, but I'm sure you know well that the Linux coding style tends to
follow the GNU coding style--with modifications--which lines up args
with the first character inside the paren
(http://www.gnu.org/prep/standards/html_node/Formatting.html#Formatting-Your-Source-Code),
and it's clear that's what the previous author had done.
The hope was that you let your search and replace run awry, and I was
just pointing out that it did, so it could fixed it up. *shrug* I've
had little participation, so I don't consider my opinion to count for
much on the matter.
-John
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html