Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I just did git rebase origin/master for the umpteenth time, which
reminded me this nice patch is still pending.

ping?



m

On Thu, Jun 14, 2012 at 2:34 PM, Zbigniew Jędrzejewski-Szmek
<zbyszek@xxxxxxxxx> wrote:
> From: Martin Langhoff <martin@xxxxxxxxxx>
>
> git log -G'regex' is a very usable alternative to the classic
> pickaxe. Minimal patch to make it usable from gitk.
>
> [zj: reword message]
> Signed-off-by: Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx>
> ---
> Martin's off on holidays, so I'm sending v2 after rewording.
>
>  gitk-git/gitk | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/gitk-git/gitk b/gitk-git/gitk
> index 22270ce..24eaead 100755
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk
> @@ -2232,7 +2232,8 @@ proc makewindow {} {
>      set gm [makedroplist .tf.lbar.gdttype gdttype \
>                 [mc "containing:"] \
>                 [mc "touching paths:"] \
> -               [mc "adding/removing string:"]]
> +               [mc "adding/removing string:"] \
> +               [mc "with changes matching regex:"]]
>      trace add variable gdttype write gdttype_change
>      pack .tf.lbar.gdttype -side left -fill y
>
> @@ -4595,6 +4596,8 @@ proc do_file_hl {serial} {
>         set gdtargs [concat -- $relative_paths]
>      } elseif {$gdttype eq [mc "adding/removing string:"]} {
>         set gdtargs [list "-S$highlight_files"]
> +    } elseif {$gdttype eq [mc "with changes matching regex:"]} {
> +       set gdtargs [list "-G$highlight_files"]
>      } else {
>         # must be "containing:", i.e. we're searching commit info
>         return
> --
> 1.7.11.rc3.129.ga90bc7a.dirty
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
 martin.langhoff@xxxxxxxxx
 -  ask interesting questions
 - don't get distracted with shiny stuff  - working code first
 ~ http://docs.moodle.org/en/User:Martin_Langhoff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]