Re: [PATCH v2] clone: allow cloning local paths with colons in them

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes:

> diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh
> index 67869b4..0629149 100755
> --- a/t/t5601-clone.sh
> +++ b/t/t5601-clone.sh
> @@ -280,4 +280,9 @@ test_expect_success 'clone checking out a tag' '
>  	test_cmp fetch.expected fetch.actual
>  '
>  
> +test_expect_success NOT_MINGW,NOT_CYGWIN 'clone local path foo:bar' '
> +	cp -R src "foo:bar" &&
> +	git clone "./foo:bar" foobar
> +'

Hmph, why not

	git clone --mirror src foo:bar &&
        git clone ./foo:bar foobar

or something?  Also do we have a easy negative case we want to test,
i.e. a case where we do not want the new codepath to trigger by
mistake?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]