On Mon, May 6, 2013 at 10:18 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Michael Haggerty <mhagger@xxxxxxxxxxxx> writes: > >> Yes, it can be handy to start loading the first "blobfile" in parallel >> with the later stages of the conversion, before the second "dumpfile" is >> ready. In that case the user needs to pass --export-marks to the first >> fast-import process to export marks on blobs so that the marks can be >> passed to the second fast-import via --import-marks. >> >> So the proposed change would break a documented use of cvs2git. >> >> Making the export of blob marks optional would of course be OK, as long >> as the default is to export them. > > Thanks for a concise summary. Your use case fits exactly what > Felipe conjectured as the nonexistent minority. Not true. cvs2git does *not* rely on the blobs being stored in a marks file, because cvs2git does not rely on mark files at all. > An option that lets the caller say "I only care about marks on these > types of objects to be written to (and read from) the exported marks > file" would help Felipe's use case without harming your use case, > and would be a sane and safe way to go. His case is not harmed at all. It's only the unfortunate command that is mentioned in the documentation that didn't need to be mentioned at all in the first place. It should be the other way around, if it's only this documentation that is affected, we could add a switch for that particular command, and the documentation should be updated, but it's overkill to add a switch for one odd command in some documentation somewhere, it would be much better to update the odd command to avoid using marks at all, which is what the more appropriate command does, right below in the same documentation. cat ../cvs2svn-tmp/git-blob.dat ../cvs2svn-tmp/git-dump.dat | git fast-import Should the rest of the real world be punished because somebody added a command in some documentation somewhere, which wasn't actually needed in the first place? -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html