Quy Tonthat wrote:
If user hits enter at the prompt for
"Who should the emails appear to be from?",
the value for "From:" field was emptied instead of GIT_COMMITER_IDENT.
Signed-off-by: Quy Tonthat <qtonthat@xxxxxxxxx>
---
It seems the original code assumes readline to accept
an extra argument for default value. I don't remember I ever encountered
that feature from readline. Is there anything like that out there ?
I was thinking the same thing. Almost every call to readline() in
git-send-email is like that, so could your patch below could be expanded to
include the other instances?
$_ = $term->readline("Who should the emails be sent to? ",
"");
$_ = $term->readline("What subject should the emails start with? ",
$initial_subject);
$_= $term->readline("Message-ID to be used as In-Reply-To for the first
email? ",
$initial_reply_to);
--
Timur Tabi
Linux Kernel Developer @ Freescale
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html