On Mon, 29 Apr 2013 01:18:18 -0700, Junio C Hamano <gitster@xxxxxxxxx>
wrote:
> Here is what I'll queue.
>
> Thanks for the help, all of you.
Thank you. I will keep this conversation as a guide for possible next
patches
> -- >8 --
> From: H. Merijn Brand <h.m.brand@xxxxxxxxx>
> Subject: Git.pm: call tempfile from File::Temp as a regular function
>
> We call File::Temp's "tempfile" function as a class method, but it was
> never designed to be called this way. Older versions seemed to
> tolerate it, but as of File::Temp 0.23, it blows up like this:
>
> $ git svn fetch
> 'tempfile' can't be called as a method at .../Git.pm line 1117.
>
> Fix it by calling it as a regular function, just inside the File::Temp
> namespace.
>
> Signed-off-by: H. Merijn Brand <h.m.brand@xxxxxxxxx>
> Helped-by: Jeff King <peff@xxxxxxxx>
> ---
> perl/Git.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/perl/Git.pm b/perl/Git.pm
> index 497f420..76383b9 100644
> --- a/perl/Git.pm
> +++ b/perl/Git.pm
> @@ -1039,7 +1039,7 @@ sub _temp_cache {
> $tmpdir = $self->repo_path();
> }
>
> - ($$temp_fd, $fname) = File::Temp->tempfile(
> + ($$temp_fd, $fname) = File::Temp::tempfile(
> 'Git_XXXXXX', UNLINK => 1, DIR => $tmpdir,
> ) or throw Error::Simple("couldn't open new temp file");
>
--
H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/
using perl5.00307 .. 5.17 porting perl5 on HP-UX, AIX, and openSUSE
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/
http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html