Re: [PATCH] send-email: improve recipients_cmd()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 29, 2013 at 12:24 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Felipe Contreras <felipe.contreras@xxxxxxxxx> writes:
>
>>>         open $fh, "-|", qw(sh -c), $cmd, @args
>>
>> That doesn't seem to work for me.
>
> My fault.  It needs to form a command line like this:
>
>         sh -c 'cccmd --frotz --nitfol "$@"' - a r g s
>
> [jc: goes and tries
>         $ sh -c 'echo X Y "$@"' - a r g s
>         X Y a r g s
> ]
>
> so if we want to get rid of \Q\E, it would be:
>
>         open $fh, '-|', qw(sh -c), "$cmd " . '"$@"', '-', @args
>

I don't know if that would be better, or converting @args to a list of
quoted strings, essentially keeping the current behavior.


-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]