On Sat, Apr 27, 2013 at 2:42 PM, Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx> wrote: > > On MinGW, sparse issues an "'get_st_mode_bits' not declared. Should > it be static?" warning. The MinGW and MSVC builds do not see the > declaration of this function, within git-compat-util.h, due to it's s/it's/its/ > placement within an preprocessor conditional. (So, one solution would > be to simply move the declaration to the top level of the header.) > > In order to suppress the warning, since this symbol does not need > more than file visibility, we simply remove the declaration from > the header and add the static modifier to the function definition. > > Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html