On Sat, Apr 27, 2013 at 8:19 PM, Duy Nguyen <pclouds@xxxxxxxxx> wrote:
> On Sun, Apr 28, 2013 at 4:16 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> That was fairly hard to grok. Is that equivalent to this?
>>
>> if (c == ':' && path < strchrnul(host, '/')) {
>> /* is the first slash past the colon? */
>> protocol = PROTO_SSH;
>> *path++ = '\0';
>> } else {
>> path = end;
>> }
>>
>
> The original code is already hard to grok so I may be mistaken here.
> But I think it's not the same. For the case when c == '/', it will do
> "path = end;", which is unintended. It should keep the current "path"
> value (i.e. == strchr(end, '/')). The use of "strchrnul(host, '/')" is
> good though.
Do you want to take Windows '\' into account also?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html