Hi, In the previous series I didn't notice -o filenames actually did something useful, so in this series it's still used, however, for versions older than 4, we use a hack to enable it. This allows us to get rid of a lot of compat code. I also got rid of some wrappers, and fixed a regression: spaces were not added at the end of the completion. The result is that now we have the same completion for bash < 4, bash >=4, and zsh. Although we already had that for the last two, now the code is simpler. The only difference is that bash < 4 doesn't add a trailing space, like before fea16b4 (git-completion.bash: add support for path completion). Also, add the missing tests. Cheers. Felipe Contreras (9): completion: add file completion tests completion: document tilde expansion failure in tests completion; remove unuseful comments completion: use __gitcompadd for __gitcomp_file completion: refactor diff_index wrappers completion: refactor __git_complete_index_file() completion: add hack to enable file mode in bash < 4 completion: add space after completed filename completion: remove __git_index_file_list_filter() contrib/completion/git-completion.bash | 145 +++++++-------------------------- t/t9902-completion.sh | 77 +++++++++++++++++ 2 files changed, 107 insertions(+), 115 deletions(-) -- 1.8.2.1.1031.g2ee5873 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html