Hi Junio, These patches are from a long running branch on MinGW; I have been updating this branch for about four years now! The main reason for not submitting these patches before is simply that I haven't sent my patches to port sparse to MinGW upstream yet. So, as far as I know, nobody can confirm/deny that these patches actually fix a problem. :-D Note that the first 5 patches are fairly straight forward and shouldn't be controversial. I don't think the same can be said of the final patch, especially since it reverts a recent trend (to make the argv parameter of main() a const char **). [Note: after this and the previous series, both cygwin and MinGW are sparse clean. Linux still has about 8 warnings related to the use of transparent unions in the library headers (all sockaddr types), which requires a patch to sparse.] ATB, Ramsay Jones Ramsay Jones (6): compat/unsetenv.c: Fix a sparse warning compat/win32/pthread.c: Fix a sparse warning compat/poll/poll.c: Fix a sparse warning compat/win32mmap.c: Fix some sparse warnings compat/mingw.c: Fix some sparse warnings sparse: Fix mingw_main() argument number/type errors compat/mingw.c | 6 +++--- compat/mingw.h | 11 +++++++++-- compat/poll/poll.c | 2 +- compat/unsetenv.c | 1 - compat/win32/pthread.c | 2 +- compat/win32mmap.c | 4 ++-- credential-store.c | 4 ++-- fast-import.c | 4 ++-- git.c | 3 ++- remote-testsvn.c | 2 +- test-chmtime.c | 2 +- test-index-version.c | 2 +- test-mergesort.c | 2 +- test-parse-options.c | 4 ++-- test-subprocess.c | 4 ++-- 15 files changed, 30 insertions(+), 23 deletions(-) -- 1.8.2 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html