Re: [PATCH] t9501: Do not use export X=Y

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Torsten Bögershausen <tboegi@xxxxxx> writes:

> On 2013-04-25 22.46, Junio C Hamano wrote:
>> Torsten Bögershausen <tboegi@xxxxxx> writes:
>> 
>>> Spilt lines like export X=Y into 2 lines:
>>> X=Y
>>> export X
>> 
>> That can be read from the patch text.
>> 
>> If you are going to spend three lines, please describe why it has to
>> be split; that would help educate developers new to the codebase.
>> 
> So true,
> writing good commit messages is not easy.
> and this was a good example for a bad example
>
> Side questions:
> Which shells of which OS/distribution do not understand export X=Y?

I have not met one for quite some time myself. cf.

http://thread.gmane.org/gmane.comp.version-control.git/35543/focus=35551
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]