Re: [PATCH 0/2] "git add -A/--no-all" finishing touches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> writes:

> Jonathan Nieder <jrnieder@xxxxxxxxx> writes:
>
>> Junio C Hamano wrote:
>>
>>> At the point of calling warn_pathless_add(), it seems that we are
>>> triggering this for paths that are not necessarily modified when run
>>> with "add -n -u".
>>
>> Do you mean files that were touched but have no content change, or
>> something more subtle?
>
> I had the change (which by the way needs a fix for the "found a
> directory" codepath) on top of master, uncommitted, and no other
> change (I also have some cruft that is not ignored).
>
>     cd Documentation && ../git add -n -u
>
> reported GIT-VERSION-GEN which was not touched.  It does not
> reproduce, though...

Ahh, I haven't run anything under the debugger yet, but I think I
know what is going on.

Don't we limit our "update-index --refresh" equivalent to the
original pathspec, even though your "-u/-A sans pathspec" warning
detection relies on grabbing the changes from the entire tree?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]