On Thu, Apr 25, 2013 at 2:29 PM, Stefano Lattarini <stefano.lattarini@xxxxxxxxx> wrote: > On 04/25/2013 08:19 PM, Ramkumar Ramachandra wrote: >>> @@ -521,7 +521,7 @@ def c_style_unescape(string): >>> return string >>> >>> def parse_commit(parser): >>> - global marks, blob_marks, bmarks, parsed_refs >>> + global marks, blob_marks, parsed_refs >> >> How is this trivial? You just removed one argument. >> > Maybe bmarks was no longer used there as a global variable > (left-over from previous patches?), so there is no longer any > need to declare it global. Even more, it never was used, it was a mistake carried when copying this method from remote-hg; we don't have bookmarks in bazaar. And bmarks wasn't even used in this method in remote-hg either =/ But it would be obvious that it was not used once one ran the tests and they passed, which they do. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html