[PATCH] check-non-portable-shell: Check for non portable grep usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The make test-lint could check for some common non portable
grep usage:

The + as a qualifier is not a "basic regular expression".
Some grep understand \+, but in general egrep should be used.

The \t can not be used to find an ASCII TAB, neither
can \s be used to find a whitespace

Signed-off-by: Torsten Bögershausen <tboegi@xxxxxx>
---
 t/check-non-portable-shell.pl | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/t/check-non-portable-shell.pl b/t/check-non-portable-shell.pl
index ff87611..58f8e2c 100755
--- a/t/check-non-portable-shell.pl
+++ b/t/check-non-portable-shell.pl
@@ -16,6 +16,8 @@ sub err {
 
 while (<>) {
 	chomp;
+	/ e?grep\s+\"[^"]*\\([st])/ and err "grep \\$1 is not portable)";
+	/ [^e]grep.*\\\+/ and err 'grep with \+ is not portable (please use egrep)';
 	/^\s*sed\s+-i/ and err 'sed -i is not portable';
 	/^\s*echo\s+-(\S)\s+/ and err "echo -$1 is not portable (please use printf)";
 	/^\s*declare\s+/ and err 'arrays/declare not portable';
-- 
1.8.2.1.614.g66d7af5


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]