Jeff King venit, vidit, dixit 20.04.2013 06:17:
> On Fri, Apr 19, 2013 at 06:44:46PM +0200, Michael J Gruber wrote:
>
>> - die("git cat-file --textconv: unable to run textconv on %s",
>> - obj_name);
>> - break;
>> + if (textconv_object(obj_context.path, obj_context.mode, sha1, 1, &buf, &size))
>> + break;
>> +
>> + /* otherwise expect a blob */
>> + exp_type = "blob";
>>
>> case 0:
>> if (type_from_string(exp_type) == OBJ_BLOB) {
>
> I'm not sure this is right. What happens with:
>
> git cat-file --textconv HEAD:Documentation
>
> We have failed to textconv, but should we be expecting a blob?
Very true, thanks. I'll reorder so that the --textconv case continues
(without break) into the -p case. I think it makes sense to consider
"--textconv" to be "at least as pretty as -p".
Michael
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html