Andy Whitcroft <apw@xxxxxxxxxxxx> writes: >> - strcpy(filename + len, ".txt"); >> + sprintf(filename + len, ".%s", fmt_patch_suffix); > > This doesn't give us any possibility of not having a suffix. Can we not > include the . in the suffix here so that we can specify it as "". I've considered it, but I do not think it is worth it. If we did so, the configuration would look like: [format] suffix = .txt which has a certain "Huh?" factor, and more importantly, a careless user would end up with a patchfile that is named: 0001-Introduce-git-format-patch-suffix-patchtxt which is I think much worse than not being able to say: 0001-Introduce-git-format-patch-suffix-patch But I do not care that much either way. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html