Re: [PATCH v2 4/6] transport-helper: warn when refspec is not used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 18, 2013 at 12:30 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Felipe Contreras <felipe.contreras@xxxxxxxxx> writes:
>
>> For the modes that need it. In the future we should probably error out,
>> instead of providing half-assed support.
>>
>> The reason we want to do this is because if it's not present, the remote
>> helper might be updating refs/heads/*, or refs/remotes/origin/*,
>> directly, and in the process fetch will get confused trying to update
>> refs that are already updated, or older than what they should be. We
>> shouldn't be messing with the rest of git.
>
> So that answers my question in the response to an earlier one in
> this series.  We expect the ref updates to be done by the fetch or
> push that drives the helper, and do not want the helper to interfere
> with its ref updates.
>
> So it is not just 'refspec' _allows_ the refs to be constrained to a
> private namespace, like the earlier updates made the documentation
> say; it _is_ mandatory to use refspecs to constrain them to avoid
> touching refs/heads and refs/remotes namespace.

Yeah, it was not stated that it was mandatory, but I think it's in
everybody's best interest that it is.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]