Re: [RFC] Add a suffix option to git-format-patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/17/07, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote:
Hi,

On Wed, 17 Jan 2007, Josh Boyer wrote:

> Could we add an option to git-format-patch to use ".patch" as the file
> suffix instead of ".txt"?  Something like the below?
>
> diff --git a/builtin-log.c b/builtin-log.c
> index a59b4ac..4eb2d32 100644
> --- a/builtin-log.c
> +++ b/builtin-log.c
> @@ -217,6 +217,7 @@ static int git_format_config(const char *var,
> const char *value)
>
> static FILE *realstdout = NULL;
> static const char *output_directory = NULL;
> +static int psuffix = 0;

Why not

        static const char *file_extension = ".txt"

Hmm?

Yes, that's better.  I was more going for "would something like this
option be accepted" to start with.  And I'm lazy, so the patch I wrote
was just an example for my specific use case :).

You'd call it with "--extension=.patch", and if you really want, you can
make a config variable from it.

Good idea.  I'll try and get this done soon-ish.  I'm not very
familiar with the git code, so if someone beats me to it, I won't be
disappointed in the least ;)

josh
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]