On Wed, Apr 17, 2013 at 9:10 AM, Torsten Bögershausen <tboegi@xxxxxx> wrote: > The test cases in contrib/remote-helpers use mercurial and python. > Before the tests are run, we check if python can import > "mercurial" and "hggit". > To run this check, python pointed out by PYTHON_PATH is used. > This may not work when different python binaries exist, > and PYTHON_PATH is not set: > Makefile sets it to the default /usr/bin/python > The PATH may point out e.g. /sw/bin/python. > When /sw/bin/python has the mercurial module installed, > but /usr/bin/python has not, the test will not be run. > > Git respects PYTHON_PATH, hg does not. > Use python instead of $PYTHON_PATH to check for installed modules. And this would fail if the distribution doesn't have a 'python' binary, and instead has python2, python3, etc. > While at it, split exportX=Y into 2 lines Do it in a separate patch. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html