Re: [Resend PATCH] t3903 (stash): add failing test for ref of form ^{/message}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 16, 2013 at 12:11 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Brandon Casey <drafnel@xxxxxxxxx> writes:
>
>> The stash is implemented using the reflog.  The ^{/<text>} notation
>> searches the commit history, not the reflog.  So I think it will be
>> able to match the first entry in your stash stack, but not any of the
>> other ones.
>
> Good point, together with...
>
>> An extension to the reflog dwimery that implements @{/<text>} could be
>> interesting though.
>
> "log -g --grep=<text>" gives you a way to eyeball, but with
> @{/<text>} you _might_ have a good way to name the revision.
>
> I am not however so sure if it is useful outside the context of the
> stash, because the ones you would want to recover from a normal
> reflog is most likely the older version of what you already amended,
> so the latest hit will likely be the post-amend version, not the one
> closer to the original.  You would end up eyeballing the output of
> "log --oneline -g -grep=<text>" and cutting from it.

Yeah, I think that's true.  I can't think of a reason, at the moment,
where it would be useful outside of with 'git stash'.  I mainly wanted
to spell out "@{/<text>}" so that the mental link could be made back
to the code in git-stash that removes the "@*" suffix.

-Brandon
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]