Re: [PATCH] rebase-am: fix regression with new cover-letter config

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Felipe Contreras <felipe.contreras@xxxxxxxxx> writes:

>> You are mean to say "fix regression", which gave me a small heart
>> attack ;-).  I was worried if we had already merged it to 'next'.
>>
>> As I already wrote in the recent "What's cooking", the series looks
>> good to me.  I am inclined to say that we should merge it (together
>> with this update) to 'next'.
>
> Yeah, after thinking about it, it's not even really a regression,
> because people don't have format.coverletter=auto in their configs
> (yet), so the bug can't can possibly affect them.

Here is what I tentatively queued.

    rebase-am: explicitly disable cover-letter
    
    If the user has a cover-letter configuration set to anything
    other than 'false', 'git format-patch' may generate a cover
    letter, which has no place in "format-patch | am" pipeline.
    
    The internal invocatoin of format-patch must explicitly override
    the configuration from the command line, just like --src-prefix
    and other options already do.
    
    Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx>
    Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]