On Sun, Apr 14, 2013 at 11:46 AM, Felipe Contreras
<felipe.contreras@xxxxxxxxx> wrote:
> + char fancy[80];
>
> - if (show_upstream_ref)
> + if (show_upstream_ref) {
> ref = shorten_unambiguous_ref(branch->merge[0]->dst, 0);
> + if (want_color(branch_use_color))
> + snprintf(fancy, sizeof(fancy), "%s%s%s",
> + GIT_COLOR_BLUE, ref, GIT_COLOR_RESET);
> + else
> + strncpy(fancy, ref, sizeof(fancy));
> + }
> +
Please use strbuf for "fancy". I also agree with Thomas that the color
should not be hard coded.
--
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html