Re: [PATCH v3 5/5] Documentation: add caveats about I/O buffering for check-{attr,ignore}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Adam Spiers <git@xxxxxxxxxxxxxx> writes:

> On Thu, Apr 11, 2013 at 11:09:28AM -0700, Junio C Hamano wrote:
>> Reflowing of the text is very much unappreciated X-<.  
>
> I very much appreciate the excellent job you do as maintainer; your
> attention to detail results in an incredibly high quality project.
> However I do occasionally find your communication style unnecessarily
> abrasive.  Maybe that's just me.

Sorry for being me X-<.  Yeah, I agree that the above came out to be
more blunt than needed.

It is usually OK to re-flow the text in the paragraph you are
touching. After all, for the purpose of reviewing, people can just
blindly apply and then ask "diff --color-words".  In this case,
however, there was some changes that conflict in the vicinity, and
reflowing made the resolution unnecessarily more cumbersome.

I have briefly looked at this series, but it severely conflicts with
a few topics in flight that touch the infrastructure you are using,
so I haven't merged it to 'pu'. Perhaps after things calm down, we
may want to ask you to reroll on top of updated codebase.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]