Re: [PATCH v2 4/5] check-ignore: allow incremental streaming of queries via --stdin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 11, 2013 at 09:31:41PM +0100, Adam Spiers wrote:

> The shell source is strong with this one ;-)
> 
> Congrats - I first tried with FIFOs (hence my other patch which moves
> the PIPE test prerequisite definition into the core framework - the
> original intention was to reuse it here) but failed to get it working.
> I'll re-roll using your approach.

Thanks. If it make you feel any better, it took about 20 minutes of
experimenting and at least three head-scratching "wait, that _should_
have worked" moments to get it right. :)

The rest of the series looked good to me, though I admit I did not think
too hard about the "--non-matching" patch, as it looked like you and
Junio had already given some thought to the output format, which is the
tricky part.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]