On Mon, 8 Apr 2013 09:40:04 -0500
Felipe Contreras <felipe.contreras@xxxxxxxxx> wrote:
> If a push fails because the remote-helper died (with fast-export), the
> user won't see any error message. So let's add one.
>
> At the same time lets add tests to ensure this error is reported, and
> while we are at it, check the error from fast-import
>
....
> +++ b/transport-helper.c
> @@ -54,7 +54,7 @@ static int recvline_fh(FILE *helper, struct strbuf
> *buffer) if (strbuf_getline(buffer, helper, '\n') == EOF) {
> if (debug)
> fprintf(stderr, "Debug: Remote helper quit.
> \n");
> - exit(128);
> + die("Reading from remote helper failed");
Do I read this correctly? If I'm in debug mode the remote helper quit
but if not in debug mode it failed? Debuggers never fail they only quit!
> }
>
> if (debug)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html