Re: [PATCH] test-lint-duplicates: consider only numbered test cases

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 10, 2013 at 04:22:57PM +0200, Torsten Bögershausen wrote:

> Running make inside contrib/remote-helpers may fail in "test-lint-duplicates"
> 
> This was because the regexp checking for duplicate numbers strips everything
> after the first "-" in the filename, including the prefix.
> 
> As a result, 2 pathnames like
> "xxxx/contrib/remote-helpers/test-XX.sh" and
> "xxxx/contrib/remote-helpers/test-YY.sh"
> 
> are both converted into
> "xxxx/contrib/remote", and reported as duplicate.
> 
> Improve the regexp:
> - strip the leading path and look only at the basename
> - only look at files which have tNNNN- (where N stand for a digit) in the name
> 
> Signed-off-by: Torsten Bögershausen <tboegi@xxxxxx>
> ---

Yeah, I think this is fine. Though note that we already have Felipe's
patch to just set TEST_LINT explicitly, so I think it is a non-issue
now.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]