Jakub Narębski <jnareb@xxxxxxxxx> writes: > W dniu 08.04.2013 22:10, Jürgen Kreileder pisze: > >> Fix broken blob action parameters on blobdiff and commitdiff pages by >> explicitly passing variables instead of relying on global ones. > > Do I understand it correctly that those variables (e.g. $hash variable > in git_patchset_body in second chunk below, after this change passed > as parameter to format_diff_cc_simplified()) can be filled in then, > or at least adjusted correctly? Yep. >> (The broken parameters on blob links lead to blob pages which show the >> blob but with a hash instead of a commit message and have broken >> blob_plain (404 - Cannot find file) and tree links (404 - Reading tree >> failed)) > > I wonder how we missed this. Does this happen always, or in some > specific conditions? Just having a hash in the diff header and missing navigation links for lhs links in diffs happen pretty much all the time: E.g. follow any a/... link on http://repo.or.cz/w/alt-git.git/commitdiff/5bda18c186e455f8e65f976d3bf333ab1f4b5b53 (Btw, on http://repo.or.cz/w/alt-git.git/blobdiff/6466fbbeef67ec398f6f5d5b5da5d6f107a647b2..5bda18c186e455f8e65f976d3bf333ab1f4b5b53:/GIT-VERSION-GEN both the a/ und b/ link are broken. No idea if my patch fixes that, I don't use pathinfo because I've had similar problems with it when I tested it a year ago). Broken a/ and b/ + broken tree + broken blob_plain links are more rare. I see them on https://git.blackdown.de/old.cgi?p=contactalbum.git;a=blobdiff;f=Classes/ContactAlbum.h;h=8f2b6a772ba0a4530e0c441db53ae5bbc0f2e277;hp=03c43ea01a3a88bbce3c73df9bfde64ee7a13717;hb=cc4eaa64c2b399dd9bdbf1f67f6d621aa24df5f8;hpb=43ff97d2c247517f43d83314aaa215e9f61d5d0c;js=1 for example: When following either a/ or b/, all links in "[contactalbum.git] / Classes / ContactAlbum.h" are broken. With my patch I don't see these problems: https://git.blackdown.de/?p=contactalbum.git;a=blobdiff;f=Classes/ContactAlbum.h;h=8f2b6a772ba0a4530e0c441db53ae5bbc0f2e277;hp=03c43ea01a3a88bbce3c73df9bfde64ee7a13717;hb=cc4eaa64c2b399dd9bdbf1f67f6d621aa24df5f8;hpb=43ff97d2c247517f43d83314aaa215e9f61d5d0c;js=1 Juergen -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html