W dniu 09.04.2013 19:40, Jürgen Kreileder napisał: > Jakub Narębski <jnareb@xxxxxxxxx> writes: >> Jürgen Kreileder wrote: >> >>> Properly encode site and project names for RSS and Atom feeds. >>> - my $title = "$site_name - $project/$action"; >>> + my $title = to_utf8($site_name) . " - " . to_utf8($project) . "/$action"; >> Was this patch triggered by some bug? > > Yes, I actually see broken encoding with the old code, e.g on > https://git.blackdown.de/old.cgi?p=contactalbum.git;a=rss > my first name is messed up in the title tag. > > New version: https://git.blackdown.de/?p=contactalbum.git;a=rss > >> Because the above is not necessary, as git_feed() has >> >> $title = esc_html($title); >> >> a bit later, which does to_utf8() internally. > > Good point. But it doesn't fix the string in question: > It looks like to_utf8("$a $b") != (to_utf8($a) . " " . to_utf8($b)). Strange. I wonder if the bug is in our to_utf8() implementation, or in Encode, or in Perl... and whether this bug can be triggered anywhere else in gitweb. What Perl version and Encode module version do you use? -- Jakub Narębski -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html