Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > Hi, > > On Fri, 12 Jan 2007, Junio C Hamano wrote: > >> Side note. The previous patch does not help if your commit were >> made in non UTF-8 with not too recent git; the code assumes that >> commit messages without the new "encoding" headers are in UTF-8. > > Why not just use is_utf8() and warn, or error out, if the message is not > UTF-8? (I tend towards the erroring out, since this _is_ a new feature, > and gives undesired results with "old" commits.) What do you mean? I have an old repository with latin1 commits without any encoding markers. I want to be able to use format-patch from that and at least get a From: line with something readable. You can't just barf and say "This isn't UTF-8, go away". -- David Kågedal - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html