At 16:51 -0700 07 Apr 2013, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
- char *ref_git;
+ char *ref_git, *repo;
[...]
+ repo = (char *)read_gitfile(mkpath("%s/.git", ref_git));
Why not make repo a "const char *" and avoid the cast? The above
would seem to make it too tempting to treat the return value from
read_gitfile() as a mutable buffer instead of a real_path string that
should be copied asap.
Good catch. I'll fix that in the next version.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html