Hi, Simon Ruderich wrote: > On Sun, Apr 07, 2013 at 12:46:23PM -0500, Felipe Contreras wrote: >> +test_expect_success 'cover letter auto' ' >> + mkdir -p tmp && >> + test_when_finished "rm -rf tmp; [...] > I'm not sure if it's better to use test_when_finished with rm or > just && rm -rf tmp at the end of the test in case someone wants > to look at the output. test_when_finished is better here, since it means later tests can run and provide useful information about how bad a regression is. Cleanup commands requested using test_when_finished are not run when a test being run with --immediate fails, so you can still inspect output after a failed test. Thanks and hope that helps, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html