On Sat, Apr 6, 2013 at 9:32 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Felipe Contreras <felipe.contreras@xxxxxxxxx> writes:
>
>> @@ -305,6 +306,7 @@ my $rc = GetOptions("h" => \$help,
>> "smtp-domain:s" => \$smtp_domain,
>> "identity=s" => \$identity,
>> "annotate" => \$annotate,
>> + "no-annotate" => \$no_annotate,
>
> Wouldn't it be much better to let GetOptions know that --no-annotate
> is allowed by saying
>
> "annotate!" => \$annotate
>
> which also let us lose an extra $no_annotate variable?
Right. Will resend.
--
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html