Re: [PATCH V3 2/5] Help.c use OPT_BOOL and refactor logic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sent: Wednesday, April 03, 2013 2:13 AM
Junio C Hamano <gitster@xxxxxxxxx> writes:

You are creating a gap in the output so that you can add some more
stuff in later patches, which is fine, but I do not think we call
that kind of change a "refactor" ;-).

The change looks fine.

I'll queue what I suggested on 'pu' for now.

It looks good. I'm happy with your suggestions as queued.

Acked-by: Philip Oakley <philipoakley@xxxxxxx>

Longer term I'd like to be able to show all the guides as a double -gg
option, but this is a great start.


Thanks.


-----

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]