Re: [PATCH 07/13] remote-hg: redirect buggy mercurial output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Felipe Contreras <felipe.contreras@xxxxxxxxx> writes:

> On Tue, Apr 2, 2013 at 1:58 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> Felipe Contreras <felipe.contreras@xxxxxxxxx> writes:
>>
>>> We can't use stdout for that in remote helpers.
>>>
>>> Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx>
>>> ---
>>
>> You may want to clarify "buggy output" a bit.  Will mercurial
>> forever be broken?  Some versions of Hg emit [[[it is unclear for
>> Junio to tell what it is to fill this blank]]] to its output that
>> we want to ignore?
>
> The problem is that mercurial's code is kind of hardcoded to run under
> mercurial's UI, so it throws messages around willynillingly, like:
>
> searching for changes
> no changes found
>
> And they can't be turned off. Theoretically we could override
> mercurial's UI class, but I think that has the potential to create
> more problems, it's not worth at this point in time.

Oh, I totally agree with you _after_ reading that explanation.

You just shouldn't let me waste your time to explain that to me in
this exchange, and you could have done so by writing a clearer log
message.  That's all.

>
> Cheers.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]