Junio C Hamano wrote: > Note that we leave "return undef;" in validate_address on purpose, > even though Perlcritic may complain. The primary "return" site of > the function returns whatever is in the scaler variable $address, so > it is pointless to change only the other "return undef;" to "return". > The caller must be prepared to see an array with a single undef as > the return value from this subroutine anyway. The way I understood it: All callsites only ever call validate_address via validate_address_list, which in turn maps a list of addresses by calling validate_address on each address. Therefore, validate_address returning an undef in one codepath is correct. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html