Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > The last use of check_everything_connected after this series is > fetch.c:quickfetch(), which I think is unnecessary. It can only catch > errors if we have incomplete object islands in repo, which could > happen before this series. A typical source of object islands the quickfetch() was designed to protect against is the HTTP walker. I do not think your patch adds any safety in that area (nor it should). > After this series, incomplete object > islands can't enter the repository, at least via git transport. Exactly. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html