Jeff King wrote: > [...] So, you're saying: don't test compound statements for failure, since anything in the chain could fail and propagate failure. I should only test simple git-foo commands for failure? > Sometimes it's annoyingly verbose to break down a compound function. But > I think in this case, you can make your tests more robust by just > checking the affirmative that the ref is still where we expect it to be, > like: > > check_push_result up_repo $the_first_commit heads/master Doesn't that change the meaning of the test though? I really like how the original tests read. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html