Re: [PATCH] t1300: document some aesthetic failures of the config editor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 29, 2013 at 01:35:22PM -0700, Junio C Hamano wrote:

> Jeff King <peff@xxxxxxxx> writes:
> 
> > Here it is with the updated expectation. I don't care _that_ much, so if
> > you feel strongly and want to drop the first test, feel free.
> 
> As long as we are adding expect_failure without an immediate fix,
> let's document the ideal, with this patch on top.
> [...]
>  test_expect_failure 'unsetting the last key in a section removes header' '
>  	cat >.git/config <<-\EOF &&
> +	# some generic comment on the configuration file itself
> +	# a comment specific to this "section" section.
>  	[section]
>  	# some intervening lines
>  	# that should also be dropped
>  
>  	key = value
>  	EOF
>  
> -	>expect &&
> +	cat >expect <<-\EOF &&
> +	# some generic comment on the configuration file itself
> +	EOF

I think we may not attain that ideal without some natural language
processing of the comments. But hey, no reason not to shoot for the
stars. :)

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]