Re: [PATCH] cherry-pick -x: improve handling of one-liner commit messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 29, 2013 at 10:23 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Miklos Vajna <vmiklos@xxxxxxx> writes:
>
>> git cherry-pick -x normally just appends the "cherry picked from commit"
>> line at the end of the message, which is fine. However, in case the
>> original commit message had only one line, first append a newline,
>> otherwise the second line won't be empty, which is against
>> recommendations.
>> ---
>
> Sign-off?
>
> I think this is part of the bc/append-signed-off-by topic that is
> about to graduate to 'master'; more specifically, b971e04f54e7
> (sequencer.c: always separate "(cherry picked from" from commit
> body, 2013-02-12) does the equivalent, no?

Yeah, I think this case is already handled.

Miklos, can you check out next and see if your problem case is handled?

-Brandon
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]