Re: [PATCH 4/6] dir.c::match_pathname(): pay attention to the length of string parameters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 29, 2013 at 6:32 PM, Torsten Bögershausen <tboegi@xxxxxx> wrote:
>> Just tested. t0003 and t3001 on 'pu' work for me because I have
>> USE_WILDMATCH on (which turns FNM_PATHNAME to WM_PATHNAME). Both break
>> without USE_WILDMATCH.
>>
> Hm, tested what?

Tested t0003 and t3001 with and without USE_WILDMATCH, which is pretty
much like you patch, except that wildmatch is used instead of fnmatch.

> diff --git a/dir.c b/dir.c
> index 73a08af..0b63167 100644
> --- a/dir.c
> +++ b/dir.c
> @@ -564,7 +564,7 @@ int match_pathname(const char *pathname, int pathlen,
>
>         return fnmatch_icase_mem(pattern, patternlen,
>                                  name, namelen,
> -                                FNM_PATHNAME) == 0;
> +                                WM_PATHNAME) == 0;
>  }
>
> Gives only one breakage, so we are coming closer.
>
>
> *** t3001-ls-files-others-exclude.sh ***
> [snip]
> not ok 17 - ls-files with "**" patterns
>
>
>



-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]