Re: [PATCH 3/6] t5516 (fetch-push): introduce mk_test_with_name()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 22, 2013 at 07:54:06AM -0700, Junio C Hamano wrote:

> Ramkumar Ramachandra <artagnon@xxxxxxxxx> writes:
> 
> >  mk_empty () {
> > -	rm -fr testrepo &&
> > -	mkdir testrepo &&
> > +	repo_name="$1"
> > +	test -z "$repo_name" && repo_name=testrepo
> > +	rm -fr $repo_name &&
> > +	mkdir $repo_name &&
> 
> Your quoting is sloppy in this entire patch X-<.

I meant to mention that, too. It doesn't matter, as the intent is for it
always to be a simple name like "testrepo", but that assumption is not
documented anywhere. I suspect the quoting in my patch is sloppy, too.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]