Steven Grimm <koreth@xxxxxxxxxxxxx> writes: > Junio C Hamano wrote: >> Porcelains that define SUBDIRECTORY_OK but do not do cdup are >> very valid, and they should not be cd'ed up automatically. >> > > My patch doesn't do the cd if SUBDIRECTORY_OK is defined, for exactly > that reason. Ah, I misread the patch. Sorry. But the point is that the scripts that do not currently say SUBDIRECTORY_OK have not even been audited to see if it makes sense to always cd to the top. Isn't your patch making as if they are saying SUBDIRECTORY_OK=Yes and cd to the top upfront is the right thing to do? - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html