Jonathan Nieder wrote:
> Ramkumar Ramachandra wrote:
>
>> --- a/remote.c
>> +++ b/remote.c
>> @@ -356,9 +356,7 @@ static int handle_config(const char *key, const char *value, void *cb)
>> return 0;
>> branch = make_branch(name, subkey - name);
>> if (!strcmp(subkey, ".remote")) {
>> - if (!value)
>> - return config_error_nonbool(key);
>> - branch->remote_name = xstrdup(value);
>> + git_config_string(&branch->remote_name, key, value);
>
> Shouldn't this say
>
> if (git_config_string(&branch->remote_name, key, value))
> return -1;
>
> or something?
Yes, and so should the instances in [5/6] and [6/6]. Thanks for catching it.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html