On Tue, Mar 19, 2013 at 03:50:50PM -0700, Jonathan Nieder wrote:
> This is the interesting one.
> [...]
> * summarized Peff's review with an Ack. I hope that's ok.
Yeah, OK with me. I certainly agree with the intent, and I think your
reasoning on the performance change is valid.
I don't see anything wrong in the patch itself, except for one minor
nit:
> @@ -121,17 +140,30 @@ static void update_callback(struct diff_queue_struct *q,
> }
> }
>
> +#define ADD_CACHE_IMPLICIT_DOT 32
> int add_files_to_cache(const char *prefix, const char **pathspec, int flags)
> {
> struct update_callback_data data;
> struct rev_info rev;
Should this be defined in cache.h with the other flags? I realize it's
mostly private to builtin/add.c, but without even a comment in cache.h
saying "/* 32 is reserved */", we run the risk of another commit
adding a new flag with the same number.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html