On Mon, Mar 18, 2013 at 08:26:46PM +0530, Ramkumar Ramachandra wrote:
> > Can we get rid of this duplication by having remote_get_1 take a
> > service-specific default argument? And then each service calls it like:
> >
> > struct remote *remote_get(const char *name)
> > {
> > read_config();
> > return remote_get_1(name, NULL);
> > }
> >
> > struct remote *pushremote_get(const char *name)
> > {
> > read_config();
> > return remote_get_1(name, pushremote_name);
> > }
>
> Thanks for the dose of sanity. While at it, why not move
> read_config() to remote_get_1() as well?
Because it sets pushremote_name, and therefore you would just be passing
NULL if read_config has not been run yet. But if you made it:
return remote_get_1(name, &pushremote_name);
that would work.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html